feat: s2i builder go support #2203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
knative-prow
bot
added
kind/enhancement
do-not-merge/work-in-progress
knative-prow-robot
added
the
needs-rebase
knative-prow
bot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
matzew
reviewed
Mar 11, 2024
matzew
reviewed
Mar 11, 2024
| // such that the "go build" command builds subdirectory .s2i/builds/by-func/last | ||
| // (where main resides) rather than the root. | ||
| // TODO: many apps use the pattern of having main in a subdirectory, for | ||
| // example the idiomatic "./cmd/myapp/main.go". It would therefore be |
There was a problem hiding this comment.
can we raise a GH issue for this?
There was a problem hiding this comment.
Yes, I think we should.
matzew
reviewed
Mar 11, 2024
matzew
reviewed
Mar 11, 2024
knative-prow-robot
added
needs-rebase
knative-prow-robot
removed
the
needs-rebase
knative-prow
bot
added
size/XXL
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2203 +/- ##
==========================================
- Coverage 64.21% 60.26% -3.95%
==========================================
Files 108 128 +20
Lines 13918 14831 +913
==========================================
+ Hits 8937 8938 +1
- Misses 4108 4976 +868
- Partials 873 917 +44
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
knative-prow-robot
added
the
needs-rebase
- Pulls logic for defaulting to active namespace (K8S) moved UP to CLI during flag default calculation. - Pushes logic of deciding between f.Namespace vs f.Deploy.Namespace down into implementations. - Updates some tests which needed to have their environment cleared. - Refactors Pipelines tests to use client API. - Removes namespaces as a state variable all structures, instead passing as an argument. - Moves FromTempDirectory to testing package for use outside cmd.
bumping google.golang.org/api 64f40ff...a11ef60:
> a11ef60 chore(main): release 0.177.0 (# 2545)
> e6e5ac5 chore(all): update all (# 2552)
> 3eb92f1 fix: temp patch cloud.google.com/go ambiguity (# 2560)
> 1b6db6c fix: split large compute file up (# 2546)
> fb153c0 feat(all): auto-regenerate discovery clients (# 2556)
> a5d7734 chore(deps): disable otel updates until Go 1.21 (# 2554)
> 2f46e14 feat(all): auto-regenerate discovery clients (# 2553)
> 4418f5f feat(all): auto-regenerate discovery clients (# 2551)
> f9bf96d feat(all): auto-regenerate discovery clients (# 2550)
> 32a5d10 feat(all): auto-regenerate discovery clients (# 2548)
> 2f2505b feat: reduce code size by 29% (# 2544)
bumping knative.dev/eventing 0e165f2...07ebf11:
> 07ebf11 [main] Upgrade to latest dependencies (# 7891)
bumping google.golang.org/genproto/googleapis/rpc 8c6c420...8cf5692:
> 8cf5692 chore(all): update all (# 1122)
bumping knative.dev/serving 4fe3de5...e3fa8d1:
> e3fa8d1 Update net-istio nightly (# 15185)
> 9f695f3 Update net-gateway-api nightly (# 15183)
> 2ef687c upgrade to latest dependencies (# 15182)
bumping google.golang.org/protobuf ec47fd1...242df22:
> 242df22 all: release v1.34.0
> c2b76ee all: fix deprecated
> e4ad8f9 types/gofeaturespb: move go_feature.proto to be consistent with out languages
> c2a26e7 encoding/{protojson,prototext}: strengthen wording on stability
> d0f77ae proto: ensure MarshalOptions are plumbed to all Size calls
> 94bb78c proto: return an error instead of producing invalid wire format
> 671c2db [proto] use the correct parent when resolving features for extensions
> 98873a2 internal/impl: pass ExtensionTypeDescriptor to extensionMap
> 39bbf13 proto: CSE ProtoReflect() and TypeDescriptor() in proto.HasExtension
> b30b634 protobuf: fix required/group bug in descriptor proto output of editions files
> bab4b5d protobuf: support gaps in edition defaults calculation
> a18684d protobuf: fix delimited fields under editions in go
> 8a74430 internal/cmd/generate-types: manual CSE of m.messageInfo()
> 55891d7 proto: add examples for Size, MarshalAppend (regarding allocations)
> 87fded5 internal/impl: ensure proto.HasExtension does not allocate
> 3797f00 protogen: update Options documentation. protogen.Run doesn't exist.
> 4fd828f proto: extend Unmarshal documentation, include an example
> c69658e proto: extend Marshal documentation, include an example
> 3ebf7dd proto: fix HasPresence for extensions and missing plugin response
> dea00b5 all: enable editions support
> 59034d8 reflect/protodesc: restore edition in protodesc.ToDescriptorProto
> 3039476 all: implement proto2/proto3 as editions [2/2]
> 7259b46 all: implement proto2/proto3 as editions [1/2]
> f563685 all: use subtests to identify the message type
> e216807 all: start v1.33.0-devel
bumping golang.org/x/oauth2 d0e617c...84cb9f7:
> 84cb9f7 oauth2: fix typo in comment
> 4b7f0bd go.mod: update cloud.google.com/go/compute/metadata dependency
> e11eea8 microsoft: added DeviceAuthURL to AzureADEndpoint
bumping knative.dev/pkg b69fa27...f69d19c:
> f69d19c Bump golang.org/x/oauth2 from 0.19.0 to 0.20.0 (# 3029)
> 13af413 Bump google.golang.org/api from 0.176.1 to 0.177.0 (# 3028)
bumping knative.dev/networking 979f637...6886f78:
> 6886f78 Update community files (# 975)
> 9188dac Remove requestDelay flag for tests (# 972)
> 24ed062 Update test dialer to use ip when available (# 970)
> 5f9768c Update community files (# 969)
Signed-off-by: Knative Automation <automation@knative.team>
Signed-off-by: Knative Automation <automation@knative.team>
knative-prow-robot
removed
the
needs-rebase
lkingland
requested review from
matejvasek and
gauron99
and removed request for
rhuss and
vyasgun
knative-prow-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind enhancement
Release Note