Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unreliable gitlab test skip #2186

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

gauron99
Copy link
Contributor

@gauron99 gauron99 commented Feb 27, 2024

skip gitlab test because it often fails with unrelated issue to the PR changes

issue #2185 is opened for tracking

Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2024
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@gauron99 gauron99 requested review from lkingland and removed request for navidshaikh and jrangelramos February 27, 2024 08:22
@gauron99 gauron99 removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
Signed-off-by: gauron99 <fridrich.david19@gmail.com>
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting this on the agenda for today's meeting

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2024
Copy link

knative-prow bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99, lkingland

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit fcdafd7 into knative:main Feb 27, 2024
41 checks passed
@gauron99 gauron99 deleted the gitlab-test-skip branch February 27, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants