Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for CLI commands #128

Merged
merged 2 commits into from Sep 21, 2020
Merged

Conversation

lance
Copy link
Member

@lance lance commented Sep 18, 2020

I've added some documentation for the CLI commands here and called out some odd behavior with the options in a couple of places. I wrote this as I was trying to sort out how I felt about #125 and #126 and thought that it would be a good document to use when trying to rationalize any usability changes. For the most part, I have changed my mind about #125 and #126. I'm still on the fence about faas delete, but as I wrote in the doc here, there are valid reasons to have the commands that we do and I'll just eat crow. 馃惁

Also - note that for all commands except init and create, I have documented them as they are today. For the init and create commands, I documented them as intended for #127.

Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a readable, and yet thorough write-up. Great to have as a place for discussion as well.

馃挴

docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Show resolved Hide resolved
docs/commands.md Outdated Show resolved Hide resolved
docs/commands.md Show resolved Hide resolved
Copy link
Contributor

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @lance !

@lance
Copy link
Member Author

lance commented Sep 21, 2020

Landing this. @boson-project/contributors, let's be sure to keep it updated as the commands change.

@lance lance merged commit 341d3d2 into knative:main Sep 21, 2020
@lance lance deleted the add-commands-doc branch September 21, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants