New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype a MQTT Source #7919
base: main
Are you sure you want to change the base?
Prototype a MQTT Source #7919
Conversation
Hi @ctmphuongg. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ctmphuongg The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7919 +/- ##
==========================================
+ Coverage 69.22% 69.24% +0.02%
==========================================
Files 339 345 +6
Lines 19494 15999 -3495
==========================================
- Hits 13494 11079 -2415
+ Misses 5337 4243 -1094
- Partials 663 677 +14 ☔ View full report in Codecov by Sentry. |
/cc @matzew Not sure if you have any initial feedback here... |
/cc @Leo6Leo |
@ctmphuongg I will take a look today! Thanks for your PR! |
Fixes #7207
Proposed Changes
(The main working files are cmd/mqttsource/main.go, config/tools/mqttsource/mqttsource.yaml, the rest is packages installed to use mqtt_paho, generated by using go get paho and go mod vendor)
Notes: For testing
./main -source localhost:1883 -eventType mqtt.event -eventSource mqtt://localhost:1883 -topic "test-topic"