Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add triggers to event lineage graph #7746

Merged
merged 3 commits into from Mar 19, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Mar 6, 2024

Fixes #7679

Proposed Changes

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 6, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Mar 6, 2024

/cc @Leo6Leo @matzew @creydr

@knative-prow knative-prow bot requested review from creydr, Leo6Leo and matzew March 6, 2024 22:04
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 69.19%. Comparing base (6f944bf) to head (0d16384).
Report is 9 commits behind head on main.

Files Patch % Lines
pkg/graph/constructor.go 85.71% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7746      +/-   ##
==========================================
+ Coverage   69.15%   69.19%   +0.03%     
==========================================
  Files         339      339              
  Lines       19429    19471      +42     
==========================================
+ Hits        13437    13473      +36     
- Misses       5330     5335       +5     
- Partials      662      663       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2024
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2024
Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few comments and questions, otherwise it looks good!

pkg/graph/constructor.go Show resolved Hide resolved
pkg/graph/constructor.go Show resolved Hide resolved
pkg/graph/constructor.go Show resolved Hide resolved
},
to: &Vertex{
self: &duckv1.Destination{
URI: secondUri,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding comments saying this is the Uri to the DLS would be helpful

@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 19, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
@knative-prow knative-prow bot merged commit 292e29c into knative:main Mar 19, 2024
33 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Lineage: Map Triggers to Graph Edges
3 participants