New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add triggers to event lineage graph #7746
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7746 +/- ##
==========================================
+ Coverage 69.15% 69.19% +0.03%
==========================================
Files 339 339
Lines 19429 19471 +42
==========================================
+ Hits 13437 13473 +36
- Misses 5330 5335 +5
- Partials 662 663 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left few comments and questions, otherwise it looks good!
}, | ||
to: &Vertex{ | ||
self: &duckv1.Destination{ | ||
URI: secondUri, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding comments saying this is the Uri to the DLS would be helpful
/lgtm |
Fixes #7679
Proposed Changes