Fusion Hack #7740
Fusion Hack #7740
Conversation
|
Welcome @ctmphuongg! It looks like this is your first PR to knative/eventing 🎉 |
knative-prow
bot
added
size/M
|
Hi @ctmphuongg. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow
bot
added
the
area/test-and-release
|
/cc @Leo6Leo |
|
@ctmphuongg Thanks for your PR! As this is your first time pulling up a PR in Knative community, you may need to complete a authorization called "EasyCLA". Here is a intro on what it is and how to complete it. Hope you find it is helpful! |
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7740 +/- ##
==========================================
+ Coverage 69.04% 69.15% +0.11%
==========================================
Files 338 339 +1
Lines 19350 19429 +79
==========================================
+ Hits 13360 13437 +77
- Misses 5328 5330 +2
Partials 662 662 ☔ View full report in Codecov by Sentry. |
|
/test reconciler-tests |
hack/run.sh
Outdated
| if [[ "${action}" == "install" ]]; then | ||
| source "${ROOT_DIR}"/hack/install.sh | ||
| elif [[ "${action}" == "update-cert-manager" ]]; then | ||
| source "${ROOT_DIR}"/hack/update-cert-manager.sh "$2" "$3" | ||
| elif [[ "${action}" == "e2e-debug" ]]; then | ||
| source "${ROOT_DIR}"/hack/e2e-debug.sh "$2" "$3" | ||
| elif [[ "${action}" == "generate-yamls" ]]; then | ||
| source "${ROOT_DIR}"/hack/generate-yamls.sh "$2" "$3" | ||
| elif [[ "${action}" == "update-reference-docs" ]]; then | ||
| source "${ROOT_DIR}"/hack/update-reference-docs.sh | ||
| elif [[ "${action}" == "teardown" ]]; then | ||
| source "${ROOT_DIR}"/hack/teardown.sh | ||
| elif [[ "${action}" == "update-checksums" ]]; then | ||
| source "${ROOT_DIR}"/hack/update-checksums.sh | ||
| elif [[ "${action}" == "update-codegen" ]]; then | ||
| source "${ROOT_DIR}"/hack/update-codegen.sh | ||
| elif [[ "${action}" == "update-deps" ]]; then | ||
| source "${ROOT_DIR}"/hack/update-deps.sh | ||
| elif [[ "${action}" == "verify-codegen" ]]; then | ||
| source "${ROOT_DIR}"/hack/verify-codegen.sh |
There was a problem hiding this comment.
Here, instead of sourcing the bash scripts could you directly execute them? E.g. instead of:
source "{ROOT_DIR}"/hack/script.shSimply:
./"{ROOT_DIR}"/has/script.sh
This is probably simpler and more in line with how people currently use the scripts, and it is similar to what we do in https://github.com/knative-extensions/eventing-kafka-broker/blob/7a3464cca004edecc57b8eb3fc177fe2969546c6/hack/run.sh#L90-L103
when there are scripts that we execute in their entirety rather than just calling a function defined within.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, ctmphuongg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
Fixes #7652
🧹 Create one script to call all scripts under hack