Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: brokers can be added to event lineage graph #7731

Merged
merged 2 commits into from Mar 5, 2024

Conversation

Cali0707
Copy link
Member

Fixes #7681

Proposed Changes

  • Create graph method to add a broker to the graph
  • Add some comparable types and conversion functions to use in testing, as edges aren't comparable

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Brokers are now supported in the event lineage graph

Docs

Signed-off-by: Calum Murray <cmurray@redhat.com>
Copy link

knative-prow bot commented Feb 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2024
@Cali0707
Copy link
Member Author

/cc @Leo6Leo @pierDipi @creydr

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 69.11%. Comparing base (a154f1a) to head (4317b0d).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/graph/types.go 76.19% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7731      +/-   ##
==========================================
+ Coverage   69.04%   69.11%   +0.06%     
==========================================
  Files         338      339       +1     
  Lines       19350    19398      +48     
==========================================
+ Hits        13360    13406      +46     
- Misses       5328     5330       +2     
  Partials      662      662              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! just left few questions

@@ -0,0 +1,159 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go imports problem

pkg/graph/types.go Show resolved Hide resolved
pkg/graph/types.go Show resolved Hide resolved
pkg/graph/constructor_test.go Show resolved Hide resolved
Signed-off-by: Calum Murray <cmurray@redhat.com>
@Leo6Leo
Copy link
Member

Leo6Leo commented Mar 5, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
@knative-prow knative-prow bot merged commit 95996a0 into knative:main Mar 5, 2024
34 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event Lineage: Map Brokers to Graph Nodes
2 participants