[release-1.18] Check for Auth.ServiceAccountName when the OIDC feature flag is switched on to avoid potential nil (#8582)

knative-prow-robot · matzew · creydr · web-flow · commit b4c0bfe4783d · 2025-04-30T16:23:06.000Z
* broom: when the OIDC feature flag is switched on, quickly before. It might be the case that the OIDC Service Account is not reconciled at that time

Signed-off-by: Matthias Wessendorf &lt;mwessend@redhat.com&gt;

* Update pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go

Co-authored-by: Christoph Stäbler &lt;cstabler@redhat.com&gt;

---------

Signed-off-by: Matthias Wessendorf &lt;mwessend@redhat.com&gt;
Co-authored-by: Matthias Wessendorf &lt;mwessend@redhat.com&gt;
Co-authored-by: Christoph Stäbler &lt;cstabler@redhat.com&gt;
diff --git a/pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go b/pkg/reconciler/inmemorychannel/dispatcher/inmemorychannel.go
@@ -241,7 +241,7 @@ func newConfigForInMemoryChannel(ctx context.Context, imc *v1.InMemoryChannel) (
 		}
 
 		conf.Namespace = imc.Namespace
-		if isOIDCEnabled {
+		if isOIDCEnabled && sub.Auth != nil && sub.Auth.ServiceAccountName != nil {
 			conf.ServiceAccount = &types.NamespacedName{
 				Name:      *sub.Auth.ServiceAccountName,
 				Namespace: imc.Namespace,

Original file line number	Diff line number	Diff line change
`@@ -241,7 +241,7 @@ func newConfigForInMemoryChannel(ctx context.Context, imc *v1.InMemoryChannel) (`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`conf.Namespace = imc.Namespace`
`244`		`- if isOIDCEnabled {`
	`244`	`+ if isOIDCEnabled && sub.Auth != nil && sub.Auth.ServiceAccountName != nil {`
`245`	`245`	`conf.ServiceAccount = &types.NamespacedName{`
`246`	`246`	`Name: *sub.Auth.ServiceAccountName,`
`247`	`247`	`Namespace: imc.Namespace,`