Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification service docs: Add the tutorial on how to create the slack workspace #5939

Merged
merged 3 commits into from Apr 26, 2024
Merged

Notification service docs: Add the tutorial on how to create the slack workspace #5939

merged 3 commits into from Apr 26, 2024

Conversation

ctmphuongg
Copy link
Contributor

@ctmphuongg ctmphuongg commented Apr 9, 2024 •
edited by pierDipi

Fixes #5921

Changes: Add a Markdown instructing user to create a free slack workspace, create new channels and enable Slack webhooks to receive notification.

Please let me know if more screenshots or more details are needed.

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2024
@knative-prow knative-prow bot requested review from csantanapr and snneji April 9, 2024 01:53
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 9, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 206da4f
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/662ae2e9144c2a00082f7adf
😎 Deploy Preview https://deploy-preview-5939--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctmphuongg ctmphuongg marked this pull request as ready for review April 9, 2024 01:54
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 9, 2024
@knative-prow knative-prow bot requested review from nainaz and pmbanugo April 9, 2024 01:54
@ctmphuongg
Copy link
Contributor Author

/cc @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo April 9, 2024 01:54
@pierDipi pierDipi changed the title Noti service docs Notification service docs: Add the tutorial on how to create the slack workspace Apr 9, 2024
Leo6Leo
Leo6Leo suggested changes Apr 23, 2024
View reviewed changes
Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! @ctmphuongg thanks for the work!

Only one small thing: The pictures you put here seems like not working in the markdown file.
image

code-samples/eventing/bookstore-sample-app/screenshots/webhooklink.png Show resolved Hide resolved
@Leo6Leo
Copy link
Member

Leo6Leo commented Apr 23, 2024

I have put the text into this google doc as well
https://docs.google.com/document/d/1bIav9q36UtOlLX7T7Q79JorMW3iAzJF5eu5OqPy-tbk/edit

@ctmphuongg ctmphuongg requested a review from Leo6Leo April 25, 2024 23:14
@Leo6Leo
Copy link
Member

Leo6Leo commented Apr 26, 2024

/lgtm
/approve

@ctmphuongg Thank you Phuong for finishing your 3rd PR in Knative!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ctmphuongg, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@knative-prow knative-prow bot merged commit 9b8fd63 into knative:main Apr 26, 2024
19 checks passed
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@ctmphuongg @prushh
Notification service docs: Add the tutorial on how to create the slac…
0495f68 
…k workspace (knative#5939)

* add tutorial

* create workspace docs

* Edit img
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr Awaiting requested review from csantanapr

@snneji snneji Awaiting requested review from snneji

@nainaz nainaz Awaiting requested review from nainaz

@pmbanugo pmbanugo Awaiting requested review from pmbanugo

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@Leo6Leo Leo6Leo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sample App: Notification Service: Adding the tutorial on how to create the slack workspace
2 participants
@ctmphuongg @Leo6Leo