Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample App: Event Driven Architecture I #5928

Merged
merged 10 commits into from Apr 24, 2024
Merged

Sample App: Event Driven Architecture I #5928

merged 10 commits into from Apr 24, 2024

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Mar 27, 2024

Fixes #5890
Fixes #5918

Proposed Changes

  • The code for the book review service
  • The yaml file for the Knative Broker

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 27, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 27, 2024 •
edited

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a254a2
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/66159a4aaaf79b00095d0563
😎 Deploy Preview https://deploy-preview-5928--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2024
pierDipi
pierDipi reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see deployments, sinkbindings, service called "eda", should we call them "bookstore review service" to be aligned with diagrams, text, etc ?

@Leo6Leo Leo6Leo changed the title Sample App: Event Driven Architecture Sample App: Event Driven Architecture I Apr 9, 2024
pierDipi
pierDipi approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 7f0327a into knative:main Apr 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@csantanapr csantanapr Awaiting requested review from csantanapr

@nainaz nainaz Awaiting requested review from nainaz

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@Leo6Leo @pierDipi