Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min-k8s version to 1.28 #5923

Merged
merged 1 commit into from Mar 25, 2024

Conversation

Leo6Leo
Copy link
Member

@Leo6Leo Leo6Leo commented Mar 25, 2024

Bump min-k8s version to 1.28

Proposed Changes

As it is shown here:
https://github.com/knative/pkg/blob/fd7cc2153e6a06f9cbb7a8401d5d1bcdf8edac96/version/version.go#L36

/cc @dprotaso

@knative-prow knative-prow bot requested a review from dprotaso March 25, 2024 16:12
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 25, 2024
Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6c26b60
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6601a25ec5bade00080b1f0f
😎 Deploy Preview https://deploy-preview-5923--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link

knative-prow bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, Leo6Leo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 131dc45 into knative:main Mar 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants