New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample App: Database Migration #5913
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Zazzscoot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
/cc @Leo6Leo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comment @Zazzscoot
@@ -2,6 +2,7 @@ | |||
|
|||
1. Database Schema | |||
2. Sample Data | |||
3. Deployment on K8s Cluster |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the README.md is not detailed enough, you can take a look at these 2 PRs, and see how doc is organzied. Please follow the same template, and make sure the steps are clear and well-explained. Also make sure you explain the reason behind each step.
Example 1: Sentiment Analysis Doc
Example 2: Camel-K slack sink Doc
spec: | ||
containers: | ||
- name: postgres-client | ||
image: postgres:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated in deployment.yaml
, we are using the image from quay.io. I would suggest you to use the same to be consistent.
Fixes #5891
Proposed Changes: