Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample App: Database Migration #5913

Closed
wants to merge 3 commits into from
Closed

Conversation

Zazzscoot
Copy link
Contributor

Fixes #5891

Proposed Changes:

  • Deployment pod for hosting postgres server
  • Service for exposing a port to the deployment pod
  • Job for executing sample.sql
  • Persistent Volume Claim for allowing the deployment pod to recover data in case of crashes
  • Updated README.md

Copy link

knative-prow bot commented Mar 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Zazzscoot
Once this PR has been reviewed and has the lgtm label, please assign cali0707 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from nainaz and snneji March 15, 2024 17:46
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2024
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b585aba
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65f4896bac1a880008a94306
😎 Deploy Preview https://deploy-preview-5913--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Zazzscoot
Copy link
Contributor Author

/cc @Leo6Leo

@knative-prow knative-prow bot requested a review from Leo6Leo March 15, 2024 17:46
@Zazzscoot Zazzscoot changed the title K8s job Database Migration to K8s Cluster Mar 15, 2024
@Zazzscoot Zazzscoot changed the title Database Migration to K8s Cluster Database Migration Mar 15, 2024
Copy link
Member

@Leo6Leo Leo6Leo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comment @Zazzscoot

@@ -2,6 +2,7 @@

1. Database Schema
2. Sample Data
3. Deployment on K8s Cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the README.md is not detailed enough, you can take a look at these 2 PRs, and see how doc is organzied. Please follow the same template, and make sure the steps are clear and well-explained. Also make sure you explain the reason behind each step.

Example 1: Sentiment Analysis Doc
Example 2: Camel-K slack sink Doc

spec:
containers:
- name: postgres-client
image: postgres:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in deployment.yaml, we are using the image from quay.io. I would suggest you to use the same to be consistent.

@Leo6Leo Leo6Leo changed the title Database Migration Sample App: Database Migration Mar 18, 2024
@Zazzscoot Zazzscoot closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample App: Database Service: Migration
2 participants