Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample App: Adding the db service #5909
Sample App: Adding the db service #5909
Changes from 9 commits
5d22785
e50064f
d614db8
c24329e
36f88f3
1c659ec
255759a
4ae59cb
2e4a32a
22e48c6
99aa14c
24fde1f
cc0b169
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the sentence and the point list is out of context and eventually contextualized below in
Why did we choose to deploy our PostgreSQL database using a StatefulSet instead of a Knative Service?
.I think the section below is enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the way to format a "note box"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it is a note to myself. I will edit it when we are ready to render the tutorial to pages. The issue has been created to track this #5938
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the samples page describes the point here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no page that describes the usage for the sample usage of Knative Service. Adding the new page or edit the current existing page to list the few sample usage is my thought:
E-commerce websites during sales events: traffic can spike a lot during sales events or holiday seasons. Knative Service can automatically scale the backend services up or down based on demand, ensuring that the website remains working.
Real-time analytics and monitoring: In IoT or data analytics applications, Knative can manage services that process data streams in real time. For example, a company monitoring environmental sensors across a city could use Knative to scale up data processing services as the volume of sensor data spikes.
ML model serving: serving different models based on user requirements or experimenting with A/B testing of models. It allows for the deployment of many revisions of a model and dynamically scales these services based on the request load!
Microservices and APIs: for those who use microservices architecture, Knative service provides a way to deploy and manage serverless APIs that scale automatically with usage. This is particularly useful for APIs with different traffic patterns
plz correct me if any of these are not accurate or may not be the best use case of knative service.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those are accurate, however, my point is that we can have a dedicated page for this vs being part of something unrelated, in this page, we can stay concise and link to the dedicated page on "when to use ksvc vs when not to use ksvc"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that we don't have such content / page, we can add it later as necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, I think this needs a link to next section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! In all parts of the tutorial, it will have the link navigate to the next section at the bottom to make sure the reading experience is good!