fix: pkger runs only when necessary #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes python caches on template test. This appears to be the original cause of unnecessary rebuilds. Adds pkger.go as an explict entry in the CODE prerequisite var. This ensures pkged.go is generated if it doesn't exist, and removes the need to explicitly enumerate it as a prerequisite to other targets. Adds pkger.go to the clean target. This allows a 'make clean && make' to work as one might expect. For example ensuring a rebuild if a template files is removed. The notable conceptual change here is that this does not induce a build of pkged.go by explicitly enumarating it as a prerequisite (a difficult thing to get right, and prone to errors in the future), but rather directly enumerates ./templates as its prerequisite. Additional minor modifications include: - regenerated pkged.go such that this takes effect for main on merge - adds an explicit target for the 'func' binary and aliases 'build' - Makefile help text cleanup and consolidation
knative-prow-robot
added
the
kind/bug
knative-prow-robot
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance, lkingland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
matejvasek
added a commit
to matejvasek/faas
that referenced
this pull request
Jan 16, 2023
* fix: quarkus patch Signed-off-by: Matej Vasek <mvasek@redhat.com> * fix: update productized version Signed-off-by: Matej Vasek <mvasek@redhat.com> Signed-off-by: Matej Vasek <mvasek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
馃悰 pkged.go generated only when ./templates change.
馃Ч makefile cleanup
/kind bug
Removes python caches on template test. When they existed, it caused a rebuild.
Adds pkger.go as an explicit entry in the CODE prerequisite var. This ensures pkged.go is generated if it doesn't exist, and removes the need to explicitly enumerate it as a prerequisite to other targets.
Adds pkger.go to the clean target. This allows a
make clean && maketo work as one might expect. For example ensuring a rebuild if a template file is removed.The notable conceptual change here is that make does not induce a build of pkged.go by explicitly enumerating it as a prerequisite (a difficult thing to get right, and prone to errors in the future), but rather directly enumerates ./templates as its prerequisite.