Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest dependencies and fix incompatible API call #3891

Merged
merged 2 commits into from May 13, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented May 10, 2024

Fixes incompatible call to API after merging knative/eventing#7911

Proposed Changes

  • Define InstallKafkaBrokerStepFn that is passed to newfilters.NewFiltersFeatureSet

Release Note


Docs

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.70%. Comparing base (aacc057) to head (85ef97f).
Report is 15 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3891       +/-   ##
=============================================
- Coverage     73.70%   49.70%   -24.00%     
=============================================
  Files           100      246      +146     
  Lines          3419    14849    +11430     
  Branches        292        0      -292     
=============================================
+ Hits           2520     7381     +4861     
- Misses          723     6710     +5987     
- Partials        176      758      +582     
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The NewFiltersFeatureSet now requires a different type after upgrading
dependencies.
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 10, 2024
Copy link

knative-prow bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@Cali0707
Copy link
Member

/retest-required

1 similar comment
@creydr
Copy link
Contributor

creydr commented May 10, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented May 13, 2024

/test reconciler-tests-namespaced-broker

2 similar comments
@Cali0707
Copy link
Member

/test reconciler-tests-namespaced-broker

@Cali0707
Copy link
Member

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit 29c92f5 into knative-extensions:main May 13, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants