New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest dependencies and fix incompatible API call #3891
Upgrade to latest dependencies and fix incompatible API call #3891
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3891 +/- ##
=============================================
- Coverage 73.70% 49.70% -24.00%
=============================================
Files 100 246 +146
Lines 3419 14849 +11430
Branches 292 0 -292
=============================================
+ Hits 2520 7381 +4861
- Misses 723 6710 +5987
- Partials 176 758 +582
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The NewFiltersFeatureSet now requires a different type after upgrading dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
1 similar comment
/retest-required |
/test reconciler-tests-namespaced-broker |
2 similar comments
/test reconciler-tests-namespaced-broker |
/test reconciler-tests-namespaced-broker |
29c92f5
into
knative-extensions:main
Fixes incompatible call to API after merging knative/eventing#7911
Proposed Changes
Release Note
Docs