Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post install logic for namespaced brokers #3889

Merged
merged 2 commits into from May 15, 2024
Merged

Add post install logic for namespaced brokers #3889

merged 2 commits into from May 15, 2024

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented May 9, 2024 •
edited

We currently only delete broker deployments in the system namespace. However, namespaced brokers could have deployments in any namespace.

Fixes #3815

@pierDipi
Add post install logic for namespaced brokers
4df6ec8 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane labels May 9, 2024
@codecov Codecov
Copy link

codecov bot commented May 9, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 49.48%. Comparing base (aacc057) to head (b507f99).
Report is 17 commits behind head on main.

Files Patch % Lines
...tall/kafka_namespaced_broker_deployment_deleter.go 0.00% 41 Missing ⚠️
control-plane/cmd/post-install/main.go 0.00% 21 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #3889       +/-   ##
=============================================
- Coverage     73.70%   49.48%   -24.22%     
=============================================
  Files           100      247      +147     
  Lines          3419    14911    +11492     
  Branches        292        0      -292     
=============================================
+ Hits           2520     7379     +4859     
- Misses          723     6773     +6050     
- Partials        176      759      +583
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi @Cali0707
Update control-plane/config/post-install/200-controller-cluster-role.…
b507f99 
…yaml

Co-authored-by: Calum Murray <cmurray@redhat.com>
@pierDipi
Copy link
Member Author

/retest-required

@pierDipi
Copy link
Member Author

/retest

@Cali0707
Copy link
Member

/test reconciler-tests-namespaced-broker

1 similar comment
@Cali0707
Copy link
Member

/test reconciler-tests-namespaced-broker

@pierDipi
Copy link
Member Author

@Cali0707 does this look good?

Cali0707
Cali0707 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

/test unit-tests

@matzew
Copy link
Contributor

matzew commented May 15, 2024

/retest

@pierDipi
Copy link
Member Author

/retest-required

1 similar comment
@pierDipi
Copy link
Member Author

/retest-required

@Cali0707
Copy link
Member

/test reconciler-tests

@knative-prow knative-prow bot merged commit 2571f20 into knative-extensions:main May 15, 2024
35 of 37 checks passed
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 15, 2024
@pierDipi
Add post install logic for namespaced brokers (knative-extensions#3889)
b41ae24 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi mentioned this pull request May 15, 2024
Merged
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 15, 2024
@pierDipi
Add post install logic for namespaced brokers (knative-extensions#3889)
ba18345 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 15, 2024
@pierDipi
Add post install logic for namespaced brokers (knative-extensions#3889)
0198a70 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi added a commit to pierDipi/eventing-kafka-broker that referenced this pull request May 16, 2024
@pierDipi
Add post install logic for namespaced brokers (knative-extensions#3889)
2a6d9d7 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot pushed a commit that referenced this pull request May 16, 2024
@pierDipi
Add post install logic for namespaced brokers (#3889) (#3899)
a95e409 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add post install logic for namespaced brokers
3 participants
@pierDipi @Cali0707 @matzew