Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused vertx-kafka-client from dependencies #3885

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented May 7, 2024

As per title

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot requested review from matzew and odacremolbap May 7, 2024 10:43
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/data-plane labels May 7, 2024
@pierDipi
Copy link
Member Author

pierDipi commented May 7, 2024

/cc @matzew @creydr

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@knative-prow knative-prow bot requested a review from creydr May 7, 2024 10:43
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link

knative-prow bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

pierDipi commented May 7, 2024

/test upgrade-tests

@pierDipi
Copy link
Member Author

pierDipi commented May 7, 2024

   wait.go:200: test-zixonxhy/kafka-sink-xkznaluv condition is {"type":"Ready","status":"False","lastTransitionTime":"2024-05-07T11:01:44Z","reason":"Topic is not present or invalid","message":"topics [topic-levysyej]: invalid topic topic-levysyej"}

@pierDipi
Copy link
Member Author

pierDipi commented May 7, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented May 7, 2024

/retest

@matzew
Copy link
Contributor

matzew commented May 8, 2024

/test upgrade-tests

2 similar comments
@pierDipi
Copy link
Member Author

pierDipi commented May 9, 2024

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test upgrade-tests

@pierDipi
Copy link
Member Author

/test reconciler-tests-namespaced-broker

Copy link

knative-prow bot commented May 15, 2024

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_main e8265dd link true /test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants