Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bump to new 3.10.x Quarkus.io #3872

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matzew
Copy link
Contributor

@matzew matzew commented May 2, 2024

Fixes #

Proposed Changes

  • as per title

Release Note


Docs

Copy link

knative-prow bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from creydr and pierDipi May 2, 2024 11:38
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2024
@matzew
Copy link
Contributor Author

matzew commented May 2, 2024

Let's see how this goes ...
/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.48%. Comparing base (aacc057) to head (e28884d).
Report is 18 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3872       +/-   ##
=============================================
- Coverage     73.70%   49.48%   -24.22%     
=============================================
  Files           100      247      +147     
  Lines          3419    14911    +11492     
  Branches        292        0      -292     
=============================================
+ Hits           2520     7379     +4859     
- Misses          723     6773     +6050     
- Partials        176      759      +583     
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matzew
Copy link
Contributor Author

matzew commented May 2, 2024

/test reconciler-tests

@matzew
Copy link
Contributor Author

matzew commented May 3, 2024

/retest

@pierDipi pierDipi changed the title Bump to new 3.10.x Quarkus.io [WIP] Bump to new 3.10.x Quarkus.io May 8, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2024
@matzew
Copy link
Contributor Author

matzew commented May 8, 2024

/retest

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
💫 Bump vertx to 4.5.x to match Quarkus 3.10.x

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
Copy link

knative-prow bot commented May 16, 2024

@matzew: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_eventing-kafka-broker_main e28884d link true /test unit-tests
reconciler-tests-keda_eventing-kafka-broker_main e28884d link true /test reconciler-tests-keda
channel-reconciler-tests-sasl-ssl_eventing-kafka-broker_main e28884d link true /test channel-reconciler-tests-sasl-ssl
channel-reconciler-tests-sasl-plain_eventing-kafka-broker_main e28884d link true /test channel-reconciler-tests-sasl-plain
channel-reconciler-tests-ssl_eventing-kafka-broker_main e28884d link true /test channel-reconciler-tests-ssl
reconciler-tests-namespaced-broker_eventing-kafka-broker_main e28884d link true /test reconciler-tests-namespaced-broker
reconciler-tests_eventing-kafka-broker_main e28884d link true /test reconciler-tests
upgrade-tests_eventing-kafka-broker_main e28884d link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants