Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post install logic for namespaced brokers #3815

Closed
Cali0707 opened this issue Apr 4, 2024 · 5 comments · Fixed by #3889
Closed

Add post install logic for namespaced brokers #3815

Cali0707 opened this issue Apr 4, 2024 · 5 comments · Fixed by #3889
Assignees
@pierDipi
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request

Comments

@Cali0707
Copy link
Member

Cali0707 commented Apr 4, 2024

Problem
We currently only delete broker deployments in the system namespace. However, namespaced brokers could have deployments in any namespaced. We should update our post install logic to clean those up as well.

Persona:
Which persona is this feature for?

Exit Criteria
A measurable (binary) test that would indicate that the problem has been resolved.

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.
@Cali0707
Copy link
Member Author

/help

@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 15, 2024

@Cali0707:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 15, 2024
@NeerajNagure
Copy link
Contributor

NeerajNagure commented Apr 19, 2024 •
edited

Hi @Cali0707 , my approach to do this would be to get the list of namespaces for the broker by adding this namespaceList,err = k.k8s.CoreV1().Namespaces().List(ctx,metav1.ListOptions{}) over here https://github.com/knative-extensions/eventing-kafka-broker/blob/964191004c226371d657faaf4583d19c64d8c5c5/control-plane/cmd/post-install/kafka_broker_deployment_deleter.go#L49C1-L65C2 and then iterating over the namespaceList items and delete the deployments for those namespace items.Am I right in this approach?

@Cali0707
Copy link
Member Author

Hi @NeerajNagure that sounds reasonable to me, @pierDipi or @creydr any thoughts? My only concern (and I'm not sure how to address this) is that afaik the kafka-broker-dispatcher/kafka-broker-receiver deployments in other namespaces don't have an owner reference, so we can't tell if we own that deployment or not.

@pierDipi
Copy link
Member

I think we need to go back at using deployments for namespaced brokers

@pierDipi pierDipi self-assigned this May 9, 2024
@pierDipi pierDipi mentioned this issue May 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pierDipi pierDipi

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature-request
Projects
Eventing Kafka Broker Scheduling and Scaling
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add post install logic for namespaced brokers pierDipi/eventing-kafka-broker
3 participants
@pierDipi @Cali0707 @NeerajNagure