Skip to content

Commit

Permalink
Fix broken dummy password warning on SMTP test UI. Closes #1450.
Browse files Browse the repository at this point in the history
  • Loading branch information
knadh committed Aug 15, 2023
1 parent 32b979e commit 79ff729
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion frontend/src/views/settings/smtp.vue
Expand Up @@ -301,6 +301,7 @@ export default Vue.extend({
this.$utils.toast(this.$t('settings.smtp.testEnterEmail'), 'is-danger');
this.$nextTick(() => {
const i = document.querySelector(`.password-${n}`);
this.data.smtp[n].password = '';
i.focus();
i.select();
});
Expand Down Expand Up @@ -331,7 +332,7 @@ export default Vue.extend({
if (!item.host || !item.port) {
return false;
}
if (item.auth_protocol !== 'none' && !item.password.trim()) {
if (item.auth_protocol !== 'none' && item.password.includes('')) {
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion i18n/en.json
Expand Up @@ -508,7 +508,7 @@
"settings.smtp.sendTest": "Send e-mail",
"settings.smtp.setCustomHeaders": "Set custom headers",
"settings.smtp.testConnection": "Test connection",
"settings.smtp.testEnterEmail": "Enter password to test",
"settings.smtp.testEnterEmail": "Re-enter password to test",
"settings.smtp.toEmail": "To e-mail",
"settings.title": "Settings",
"settings.updateAvailable": "A new update {version} is available.",
Expand Down

0 comments on commit 79ff729

Please sign in to comment.