Fix upload, print to support IDF v3 and v4 (and Lua 5.3) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: * Handle file.open (IDF v3) vs io.open (v4) * Removed DOWNLOAD_FILE (wasn't used anywhere) * Removed incorrect inclusions in LUA_FUNCTIONS which guaranteed that function reuse would never occur. * Replaced file.read() (old API, no longer supported in IDF v4) with fd:read() * Removed unnecessary d:sub(1,-2) which had no effect, in recv_name * Fix typo in download_file * Support 'print' command for files larger than 1024 bytes - this meant switching from using print() to uart.write() * Better error handling in 'download' if the file doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Note, the 'download' command seems to be broken on esp32 even with Lua 5.1 and IDF v3 because of line ending conversion, and I haven't fixed that here.
Tested on esp8266 (with some old Lua 5.1 ROM on it), esp32 with IDF v3 and Lua 5.1 (from dev-esp32 branch); and esp32 with v4 and Lua 5.3 (from dev-esp32-idf4 branch). IDF v4 with Lua 5.1 should work fine too. 'download' command only tested successfully on esp8266.