This repository has been archived by the owner on May 29, 2019. It is now read-only.
Added option to fail if no tests are run #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -281,7 +283,29 @@ module.exports = function(grunt) { | |||
|
|
|||
| var stats = helpers.reduceStats(testStats); | |||
|
|
|||
| if (stats.failures === 0) { | |||
There was a problem hiding this comment.
I'm about to make a 1.0 release. It seems reasonable to fail if 0 tests are run, regardless of configuration. If you're not willing to make those changes, I can make them.
|
Might be nice to have the option, but default to true? |
* 'master' of https://github.com/chrisroush/grunt-mocha: added option for failOnNoTests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue where errors thrown by my test.html would cause mocha tests to not run.
This would cause my CI to report a successful build, perhaps incorrectly.
This PR adds an option
failOnNoTestswhich will cause the task to fail if no tests are run.