Skip to content

Commit 504b8cf

Browse files
Merge pull request #191 from manikandan300/changing_cronjob_api_v1
changing cronjob api to v1
2 parents 43931c3 + d421bb6 commit 504b8cf

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

controllers/backup/cronjob.go

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import (
2525
"github.com/kloeckner-i/db-operator/pkg/utils/kci"
2626
"github.com/sirupsen/logrus"
2727
batchv1 "k8s.io/api/batch/v1"
28-
batchv1beta1 "k8s.io/api/batch/v1beta1"
2928
v1 "k8s.io/api/core/v1"
3029
"k8s.io/apimachinery/pkg/api/resource"
3130
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -34,13 +33,13 @@ import (
3433
// GCSBackupCron builds kubernetes cronjob object
3534
// to create database backup regularly with defined schedule from dbcr
3635
// this job will database dump and upload to google bucket storage for backup
37-
func GCSBackupCron(conf *config.Config, dbcr *kciv1alpha1.Database, ownership []metav1.OwnerReference) (*batchv1beta1.CronJob, error) {
36+
func GCSBackupCron(conf *config.Config, dbcr *kciv1alpha1.Database, ownership []metav1.OwnerReference) (*batchv1.CronJob, error) {
3837
cronJobSpec, err := buildCronJobSpec(conf, dbcr)
3938
if err != nil {
4039
return nil, err
4140
}
4241

43-
return &batchv1beta1.CronJob{
42+
return &batchv1.CronJob{
4443
TypeMeta: metav1.TypeMeta{
4544
Kind: "CronJob",
4645
APIVersion: "batch",
@@ -55,25 +54,25 @@ func GCSBackupCron(conf *config.Config, dbcr *kciv1alpha1.Database, ownership []
5554
}, nil
5655
}
5756

58-
func buildCronJobSpec(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1beta1.CronJobSpec, error) {
57+
func buildCronJobSpec(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1.CronJobSpec, error) {
5958
jobTemplate, err := buildJobTemplate(conf, dbcr)
6059
if err != nil {
61-
return batchv1beta1.CronJobSpec{}, err
60+
return batchv1.CronJobSpec{}, err
6261
}
6362

64-
return batchv1beta1.CronJobSpec{
63+
return batchv1.CronJobSpec{
6564
JobTemplate: jobTemplate,
6665
Schedule: dbcr.Spec.Backup.Cron,
6766
}, nil
6867
}
6968

70-
func buildJobTemplate(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1beta1.JobTemplateSpec, error) {
69+
func buildJobTemplate(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1.JobTemplateSpec, error) {
7170
ActiveDeadlineSeconds := int64(conf.Backup.ActiveDeadlineSeconds)
7271
BackoffLimit := int32(3)
7372
instance, err := dbcr.GetInstanceRef()
7473
if err != nil {
7574
logrus.Errorf("can not build job template - %s", err)
76-
return batchv1beta1.JobTemplateSpec{}, err
75+
return batchv1.JobTemplateSpec{}, err
7776
}
7877

7978
var backupContainer v1.Container
@@ -83,18 +82,18 @@ func buildJobTemplate(conf *config.Config, dbcr *kciv1alpha1.Database) (batchv1b
8382
case "postgres":
8483
backupContainer, err = postgresBackupContainer(conf, dbcr)
8584
if err != nil {
86-
return batchv1beta1.JobTemplateSpec{}, err
85+
return batchv1.JobTemplateSpec{}, err
8786
}
8887
case "mysql":
8988
backupContainer, err = mysqlBackupContainer(conf, dbcr)
9089
if err != nil {
91-
return batchv1beta1.JobTemplateSpec{}, err
90+
return batchv1.JobTemplateSpec{}, err
9291
}
9392
default:
94-
return batchv1beta1.JobTemplateSpec{}, errors.New("unknown engine type")
93+
return batchv1.JobTemplateSpec{}, errors.New("unknown engine type")
9594
}
9695

97-
return batchv1beta1.JobTemplateSpec{
96+
return batchv1.JobTemplateSpec{
9897
ObjectMeta: metav1.ObjectMeta{
9998
Labels: kci.BaseLabelBuilder(),
10099
},

0 commit comments

Comments
 (0)