Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron to v11 #317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delaguilaluis
Copy link

@delaguilaluis delaguilaluis commented Feb 11, 2021

Fixes #314 #315 #308 and their related issues.
Done by executing yarn add electron@latest.

Screenshot:
Screen Shot 2021-02-10 at 19 19 38

For tests to pass, I created the PR #316

Thanks for your attention and work on Tusk!

Copy link

@fonylew fonylew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tusk can run normally with npm start and solved the issues.

@fonylew
Copy link

fonylew commented Feb 16, 2021

also fixes #327 #326 #325 #324 #323 #321 #320 #319 #318 #311 #310

@arjun289
Copy link

arjun289 commented Feb 19, 2021

I tried locally and it works with npm start.

However, I tried running the release command and it fails
npm run release on ubuntu 20.04

> tusk@0.23.0 release /home/arjun/work/tusk-test/tusk
> build --publish always

sh: 1: build: not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! tusk@0.23.0 release: `build --publish always`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the tusk@0.23.0 release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/arjun/.npm/_logs/2021-02-19T10_25_49_341Z-debug.log

Is there a way to proceed here?

@fonylew
Copy link

fonylew commented Feb 19, 2021

It cannot run release on the main branch as well. So I don't think it is the problem from this PR. There is also a workaround mentioned in this issue #308 (comment). Maybe you can try with that. I used only npm start until there is a fix release.

@fonylew
Copy link

fonylew commented Feb 21, 2021

I tried locally and it works with npm start.

However, I tried running the release command and it fails
npm run release on ubuntu 20.04

> tusk@0.23.0 release /home/arjun/work/tusk-test/tusk
> build --publish always

sh: 1: build: not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! tusk@0.23.0 release: `build --publish always`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the tusk@0.23.0 release script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/arjun/.npm/_logs/2021-02-19T10_25_49_341Z-debug.log

Is there a way to proceed here?

This PR has solved the command in build step #332. There's also a build and release provided in the forked repository here: https://github.com/Trip09/tusk/releases/tag/v1.0.0

@arjun289
Copy link

Thanks @fonylew 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tusk is not loading any more
6 participants