Fix errors in Storage

Commands unable to run properly when app is opened for the first time. Let's fix null pointer error in the Storage class.
kkangs0226 · Sep 18, 2020 · 1e0756c · 1e0756c
1 parent f06286f
commit 1e0756c
Show file tree

Hide file tree

Showing 6 changed files with 92 additions and 41 deletions.
diff --git a/README.md b/README.md
@@ -22,6 +22,7 @@ Below are instructions on how to use _KING BOB_.
 
 ### `todo` - Add a new Todo task
 This command adds a new Todo task to the user's list of tasks.
+Duplicate tasks will not be added to the list. 
 
 Format: 
 `todo TODO_DESCRIPTION`
@@ -32,12 +33,21 @@ Example of command:
 Expected result:
 ```
 Banana! Banana has been added to your list!
-      [T][✘] read book
-   Now you have 1 banana(s) in your list! Nom nom..
+     [T][✘] read book
+Now you have 1 banana(s) in your list! Nom nom..
+```
+
+Example of command:
+- `todo read book` 
+
+Expected result:
+```
+Banana! There is a duplicate in the list!
 ```
 
 ### `event` - Add a new Event task
 This command adds a new Event task to the user's list of tasks.
+Duplicate tasks will not be added to the list. 
 
 Format: 
 `event EVENT_DESCRIPTION /at EVENT_DATE`
@@ -48,13 +58,21 @@ Example of command:
 Expected result:
 ```
 Banana! Banana has been added to your list!
-      [E][✘] graduation night (at: Feb 19 2020)
-   Now you have 2 banana(s) in your list! Nom nom..
+     [E][✘] graduation night (at: Feb 19 2020)
+Now you have 2 banana(s) in your list! Nom nom..
+```
+
+Example of command:
+- `event graduation night /at 2020-02-19`
+
+Expected result:
+```
+Banana! There is a duplicate in the list!
 ```
 
 ### `deadline` - Add a new Deadline task
 This command adds a new Deadline task to the user's list of tasks.
-
+Duplicate tasks will not be added to the list. 
 
 Format:
 `deadline PROJECT_DESCRIPTION /by DEADLINE_DATE`
@@ -65,8 +83,16 @@ Example of command:
 Expected result:
 ```
 Banana! Banana has been added to your list!
-      [D][✘] project (by: Sep 30 2020)
-   Now you have 3 banana(s) in your list! Nom nom..
+     [D][✘] project (by: Sep 30 2020)
+Now you have 3 banana(s) in your list! Nom nom..
+```
+
+Example of command:
+- `deadline project /by 2020-09-30`
+
+Expected result:
+```
+Banana! There is a duplicate in the list!
 ```
 
 ### `list` - Display list of tasks 
@@ -78,6 +104,7 @@ Format:
 Expected result:
 ```
 Banana! So many tasks?
+
 1. [T][✘] read book
 2. [E][✘] graduation night (at: Feb 19 2020)
 3. [D][✘] project (by: Sep 30 2020)
@@ -95,7 +122,7 @@ Example of command:
 Expected result:
 ```
 Banana! I’ve marked this task as done:
-      [T][✓] read book
+     [T][✓] read book
 ```
 
 ### `delete` - Delete a task 
@@ -110,8 +137,8 @@ Example of command:
 Expected result:
 ```
 Banana! banana has been eaten. Burp!
-      [T][✓] read book
-   Now you have 2 banana(s) in your list! Nom nom..
+     [T][✓] read book
+Now you have 2 banana(s) in your list! Nom nom..
 ```
 
 ### `date` - Find a task by its date
@@ -126,7 +153,7 @@ Example of command:
 Expected result: 
 ```
 Banana! Here are your bananas..
-[D][✘] project (by: Sep 30 2020)
+     [D][✘] project (by: Sep 30 2020)
 ```
 
 ### `find` - Find a task by its keyword
@@ -141,7 +168,7 @@ Example of command:
 Expected result: 
 ```
 Banana! Here are your bananas..
-[D][✘] project (by: Sep 30 2020)
+     [D][✘] project (by: Sep 30 2020)
 ```
 
 Example of command: 
@@ -150,7 +177,7 @@ Example of command:
 Expected result: 
 ```
 Banana! Here are your bananas..
-[E][✘] graduation night (at: Feb 19 2020)
+     [E][✘] graduation night (at: Feb 19 2020)
 ```
 
 ### `bye` - Exits application

diff --git a/data/duke.txt b/data/duke.txt
@@ -1,4 +1 @@
-E | 0 | graduation night | 2020-02-19
-D | 0 | project | 2020-09-30
-E | 0 | dskj | 2020-09-30
 T | 0 | read book
diff --git a/docs/README.md b/docs/README.md
@@ -5,7 +5,7 @@ tasks (bananas)!
 
 ![Image of KING BOB](https://raw.githubusercontent.com/kkangs0226/ip/master/docs/Ui.png)
 
-Below are instructions on how to use _KING BOB_.
+#####Below are instructions on how to use _KING BOB_.
 
 - Features
   - todo 
@@ -22,6 +22,7 @@ Below are instructions on how to use _KING BOB_.
 
 ### `todo` - Add a new Todo task
 This command adds a new Todo task to the user's list of tasks.
+Duplicate tasks will not be added to the list. 
 
 Format: 
 `todo TODO_DESCRIPTION`
@@ -32,12 +33,21 @@ Example of command:
 Expected result:
 ```
 Banana! Banana has been added to your list!
-      [T][✘] read book
-   Now you have 1 banana(s) in your list! Nom nom..
+     [T][✘] read book
+Now you have 1 banana(s) in your list! Nom nom..
+```
+
+Example of command:
+- `todo read book` 
+
+Expected result:
+```
+Banana! There is a duplicate in the list!
 ```
 
 ### `event` - Add a new Event task
 This command adds a new Event task to the user's list of tasks.
+Duplicate tasks will not be added to the list. 
 
 Format: 
 `event EVENT_DESCRIPTION /at EVENT_DATE`
@@ -48,13 +58,21 @@ Example of command:
 Expected result:
 ```
 Banana! Banana has been added to your list!
-      [E][✘] graduation night (at: Feb 19 2020)
-   Now you have 2 banana(s) in your list! Nom nom..
+     [E][✘] graduation night (at: Feb 19 2020)
+Now you have 2 banana(s) in your list! Nom nom..
+```
+
+Example of command:
+- `event graduation night /at 2020-02-19`
+
+Expected result:
+```
+Banana! There is a duplicate in the list!
 ```
 
 ### `deadline` - Add a new Deadline task
 This command adds a new Deadline task to the user's list of tasks.
-
+Duplicate tasks will not be added to the list. 
 
 Format:
 `deadline PROJECT_DESCRIPTION /by DEADLINE_DATE`
@@ -65,8 +83,16 @@ Example of command:
 Expected result:
 ```
 Banana! Banana has been added to your list!
-      [D][✘] project (by: Sep 30 2020)
-   Now you have 3 banana(s) in your list! Nom nom..
+     [D][✘] project (by: Sep 30 2020)
+Now you have 3 banana(s) in your list! Nom nom..
+```
+
+Example of command:
+- `deadline project /by 2020-09-30`
+
+Expected result:
+```
+Banana! There is a duplicate in the list!
 ```
 
 ### `list` - Display list of tasks 
@@ -78,6 +104,7 @@ Format:
 Expected result:
 ```
 Banana! So many tasks?
+
 1. [T][✘] read book
 2. [E][✘] graduation night (at: Feb 19 2020)
 3. [D][✘] project (by: Sep 30 2020)
@@ -95,7 +122,7 @@ Example of command:
 Expected result:
 ```
 Banana! I’ve marked this task as done:
-      [T][✓] read book
+     [T][✓] read book
 ```
 
 ### `delete` - Delete a task 
@@ -110,8 +137,8 @@ Example of command:
 Expected result:
 ```
 Banana! banana has been eaten. Burp!
-      [T][✓] read book
-   Now you have 2 banana(s) in your list! Nom nom..
+     [T][✓] read book
+Now you have 2 banana(s) in your list! Nom nom..
 ```
 
 ### `date` - Find a task by its date
@@ -126,7 +153,7 @@ Example of command:
 Expected result: 
 ```
 Banana! Here are your bananas..
-[D][✘] project (by: Sep 30 2020)
+     [D][✘] project (by: Sep 30 2020)
 ```
 
 ### `find` - Find a task by its keyword
@@ -141,7 +168,7 @@ Example of command:
 Expected result: 
 ```
 Banana! Here are your bananas..
-[D][✘] project (by: Sep 30 2020)
+     [D][✘] project (by: Sep 30 2020)
 ```
 
 Example of command: 
@@ -150,7 +177,7 @@ Example of command:
 Expected result: 
 ```
 Banana! Here are your bananas..
-[E][✘] graduation night (at: Feb 19 2020)
+     [E][✘] graduation night (at: Feb 19 2020)
 ```
 
 ### `bye` - Exits application
@@ -168,4 +195,4 @@ The app quits.
 * Images retrieved from:
   * [Background](https://www.pinterest.co.kr/pin/661114420275950559/)
   * [User icon](https://www.pinterest.com/pin/484559241150248458/)
-  * [KING BOB icon](https://despicableme.fandom.com/wiki/Bob)
+  * [KING BOB icon](https://despicableme.fandom.com/wiki/Bob)
diff --git a/docs/Ui.png b/docs/Ui.png
diff --git a/src/main/java/duke/Storage.java b/src/main/java/duke/Storage.java
@@ -46,14 +46,14 @@ public List<Task> load() throws DukeException {
             directory.mkdir();
             try {
                 dataFile.createNewFile();
-                return null;
+                return tasks;
             } catch (IOException e) {
                 throw new DukeException("File cannot be created");
             }
         } else if (!fileExists) {
             try {
                 dataFile.createNewFile();
-                return null;
+                return tasks;
             } catch (IOException e) {
                 throw new DukeException("File cannot be created");
             }

diff --git a/src/main/java/duke/Ui.java b/src/main/java/duke/Ui.java
@@ -25,7 +25,7 @@ private void resetMessage() {
      */
     public void setShowListMessage(List<Task> tasks) {
         resetMessage();
-        responseMessage.append("Banana! So many tasks?\n");
+        responseMessage.append("Banana! So many tasks?\n\n");
         Task task;
         for (int i = 0; i < tasks.size(); i++) {
             task = tasks.get(i);
@@ -49,8 +49,8 @@ public void setByeMessage() {
     public void setAddedMessage(Task task, int tasksNumber) {
         resetMessage();
         responseMessage.append("Banana! Banana has been added to your list!\n"
-                + "      " + task.toString() + "\n"
-                + "   Now you have " + tasksNumber + " banana(s) in your list! Nom nom..");
+                + "     " + task.toString() + "\n"
+                + "Now you have " + tasksNumber + " banana(s) in your list! Nom nom..");
     }
 
     /**
@@ -69,8 +69,8 @@ public void setDuplicateMessage() {
     public void setDeletedMessage(Task task, int tasksNumber) {
         resetMessage();
         responseMessage.append("Banana! Banana has been eaten. Burp!\n"
-                + "      " + task.toString() + "\n"
-                + "   Now you have " + (tasksNumber - 1) + " banana(s) in your list! Nom nom..");
+                + "     " + task.toString() + "\n"
+                + "Now you have " + (tasksNumber - 1) + " banana(s) in your list! Nom nom..");
     }
 
     /**
@@ -80,7 +80,7 @@ public void setDeletedMessage(Task task, int tasksNumber) {
     public void setDoneMessage(Task task) {
         resetMessage();
         responseMessage.append("Banana! I've marked this task as done:\n"
-                + "      " + task.toString());
+                + "     " + task.toString());
     }
 
     /**
@@ -101,7 +101,7 @@ public void setFindTaskByDateMessage(LocalDate date, List<Task> tasks) {
         responseMessage.append("Banana! Here are your bananas..\n");
         for (Task t : tasks) {
             if (t.getDate().equals(date)) {
-                responseMessage.append(t.toString() + "\n");
+                responseMessage.append("     " + t.toString() + "\n");
             }
         }
     }
@@ -116,7 +116,7 @@ public void setFindTaskByKeywordMessage(String keyword, List<Task> tasks) {
         responseMessage.append("Banana! Here are your bananas..\n");
         for (Task t : tasks) {
             if (t.toString().contains(keyword)) {
-                responseMessage.append(t.toString() + "\n");
+                responseMessage.append("     " + t.toString() + "\n");
             }
         }
     }