13.) Cleanup rotation example #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 15, 2020 14:23
AndreMiras
approved these changes
Jun 21, 2020
Comment on lines
+6
to
+11
| from kivy3 import Scene | ||
| from kivy3 import Renderer | ||
| from kivy3 import PerspectiveCamera | ||
| from kivy3 import Geometry | ||
| from kivy3 import Material | ||
| from kivy3 import Mesh |
There was a problem hiding this comment.
I'm still not convinced it's the most Pythonic way to deal with this 😅
For instance look how black or isort are dealing with imports
Edit: Just sharing my though, but don't change it, I think rnixx prefers it this way and it's consistent with the other changes
rnixx
reviewed
Jun 22, 2020
examples/rotation/main.py
Outdated
| @@ -158,12 +153,13 @@ def build(self): | |||
| root.controls = controls | |||
| box.add_widget(controls) | |||
|
|
|||
| return box | |||
| def _adjust_aspect(inst, val): | |||
There was a problem hiding this comment.
Please make _adjust_aspect a class member again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.