Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

fix: failed cross-platform build #386

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

dwisiswant0
Copy link
Member

@dwisiswant0 dwisiswant0 commented Feb 13, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first!

(Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request).

Summary

  • update goreleaser-action to v5
  • replace "release --rm-dist" with "release --clean" in release-publish.yaml
  • update Makefile to use "--clean" and "--skip=validate" options in goreleaser build command

Proposed of changes

This PR fixes/implements the following bugs/features:

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

How has this been tested?

Proof:

Closing issues

Fixes #

Checklist:

  • My code follows the code style of this project.
  • I have followed the guidelines in our CONTRIBUTING.md document.
  • My changes is cross-platform compatible (run make build-all).
  • My changes successfully ran and pass linters locally (run make lint).
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

* update goreleaser-action to v5
* replace "release --rm-dist" with "release --clean"
in release-publish.yaml
* update Makefile to use "--clean" and "--skip=validate"
options in goreleaser build command

Signed-off-by: Dwi Siswanto <me@dw1.io>
@dwisiswant0 dwisiswant0 self-assigned this Feb 13, 2024
also modify args for cross-platform checks

Signed-off-by: Dwi Siswanto <me@dw1.io>
@dwisiswant0 dwisiswant0 merged commit a730cab into v2 Feb 13, 2024
3 checks passed
@dwisiswant0 dwisiswant0 deleted the fix/failed-cross-platform-build branch February 13, 2024 04:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant