Adding temporary username functionality #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed from sending out the users pub key everytime they send a message to sending out a given username instead. This username is temporary, but atm the keys are as well so i don't see the problem.
If implementing a DB is in the future it'll all need to change anyways.
Also added some comments for functions and noted the
socket.on("disconnect")erroring out in flask in a js comment.On another note in the flask wouldn't it be easier to just hold a dict of the current users instead of a list? This would allow you to look up a user much easier? Or is there a specific reason for you doing that?