Initial E2E tests for Kimchi #1293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alinefm
reviewed
Jan 10, 2020
alinefm
reviewed
Jan 11, 2020
alinefm
reviewed
Jan 11, 2020
alinefm
reviewed
Jan 11, 2020
alinefm
reviewed
Jan 11, 2020
alinefm
requested changes
Jan 11, 2020
There was a problem hiding this comment.
@ramonmedeiros I tried to run this and seems like it is stuck in something. When I run the command it does not do anything, apparently. I am on Ubuntu 19.10
read -s pass; KIMCHI_USERNAME=XXX KIMCHI_PASSWORD=YYY DEBUG=true make
I think it may be because the PR does not include the Makefile. Shouldn't it have one inside uiTestsdir?
ramonmedeiros
force-pushed
the
add_e2e_tests
branch
from
6e7220f
to
a905e45
Compare
alinefm
requested changes
Jan 21, 2020
| @@ -38,3 +38,4 @@ po/gen-pot | |||
| *.rej | |||
| *.pem | |||
| ui/pages/help/*/*.html | |||
| tests/ui/.env | |||
|
The comments/questions I made related to dependency on Chrome and browser support on Wok PR (kimchi-project/wok#292) also make sense in here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First proposal to create E2E tests for Kimchi
The tests were created in a separated folder
uiTests, and there is a README.md with all instructions to trigger them.The tests are using Chrome and expect version
78.0.3904.105.0