New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting to blur and unblur subtitle tracks on mouse hover #413
base: main
Are you sure you want to change the base?
Conversation
5f48b9e
to
a9d9750
Compare
@nekorushi Thanks for taking the time to contribute your idea and implementation. The only major feedback I have is that I would prefer if the data model for the settings future-proofed itself against the possibility of more track-specific settings. This would make it more trivial to implement more of these types of settings for more than 3 tracks, with less code duplication, and with less hardcoding of keys that look like
|
common/locales/en.json
Outdated
"subtitleBlurTrack1": "Track 1", | ||
"subtitleBlurTrack2": "Track 2", | ||
"subtitleBlurTrack3": "Track 3", | ||
"subtitleBlurDescription": "Hides selected subtitle tracks by blurring them, can be unblurred on mouse hover", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Hides selected subtitle tracks by blurring them. Can be un-blurred on mouse hover.
Thanks @nekorushi for your contribution. It is close to merge, can you just make |
Added setting that allows for blurring of selected subtitle tracks. When mouse hovered, they unblur.