Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ios minimum deployment target - New PR #1292

Conversation

adamsousa
Copy link

New PR requested by @justinseanmartin

Original PR by @danielob #1283

@adamsousa
Copy link
Author

@justinseanmartin Hmm, 3 checks were canceled almost imminently after creating the PR. Logs are unavailable to me so I'm not able to see what's going on.

@justinseanmartin
Copy link
Contributor

Just needed approval to run. I hit the button on this, will see what comes out of the results. Thanks for picking this up!

@justinseanmartin
Copy link
Contributor

justinseanmartin commented Mar 18, 2024

First attempt failed with:

build (13.0, name=iPad Pro (12.9-inch) (5th generation),OS=15.0)

AccessibilityIdentifierPullToRefreshTests
    ✗ testPullToRefreshByAccessibilityIdentifier, The step timed out after 10.00 seconds: Failed to find accessibility element with the label "Bingo!"

build_xcode14 (14.1, name=iPad Pro (12.9-inch) (5th generation),OS=16.1)

AccessibilityIdentifierTests
    ✗ testEnteringTextIntoViewWithAccessibilityIdentifier, The step timed out after 10.00 seconds: Failed to find accessibility element with the label "Cut" 

I'm re-running to see if these are just flakes, or if they're consistently broken in the same way.

@justinseanmartin
Copy link
Contributor

Must've been flakes, because everything passed on re-run. Let me take a look at the code changes.

Copy link
Contributor

@justinseanmartin justinseanmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The repo readme should probably say iOS 11+ instead of 11-13, but your change at least makes what we report in the podspec align with the repo readme, which is great.

@justinseanmartin justinseanmartin merged commit ac6468a into kif-framework:master Mar 18, 2024
8 of 11 checks passed
@adamsousa adamsousa deleted the bump-ios-minimum-deployment-target branch March 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants