Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set animation speed for all windows #1279

Merged
merged 7 commits into from Apr 3, 2023

Conversation

steve-sun-me
Copy link
Collaborator

@steve-sun-me steve-sun-me commented Apr 2, 2023

We want to apply the same animation speed to all windows

@steve-sun-me steve-sun-me marked this pull request as ready for review April 3, 2023 15:25
});
}

- (void)swizzle_becomeKeyWindow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a scenario where we'd want this set in init as well, if a new window was created, but not made the keyWindow?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinseanmartin perhaps we only need to set this in init? Since all available UIWindows animation speed will get set due to this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added both init and initWithWindowScene

@steve-sun-me steve-sun-me merged commit 4081d3f into master Apr 3, 2023
5 checks passed
@steve-sun-me steve-sun-me deleted the setanimationspeedforallwindows branch April 3, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants