Create PaginatingLazyVStack as a generic scrollable list container #1983
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-at-kickstarter
force-pushed
the
feat/adyer/lazypaginatingvstack
branch
from
742a2d8
to
0a3a633
Compare
| } else {} | ||
|
|
||
| self.data = [] | ||
| self.addMore() |
There was a problem hiding this comment.
I learned some interesting things about Task and .refreshable by doing this. Any modification to data that is bound to the PaginatingLazyVStack causes a re-render, which will cancel any tasks that are currently pending in .refreshable. That's what self.data = [] has to happen after this Task.sleep; otherwise it's instantly re-rendered and canceled.
amy-at-kickstarter
requested review from
a team,
ifosli and
scottkicks
and removed request for
a team
Comment on lines
+7
to
+12
| @Binding var data: [Data] | ||
| @Binding var canShowProgressView: Bool | ||
|
|
||
| let onRefresh: () async -> Void | ||
| let onDidShowProgressView: () -> Void | ||
| let configureCell: (Data) -> Cell |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📲 What
Add
PaginatingLazyVStackto our component library.🤔 Why
As part of SwiftUI work, I'm working on re-writing the old backer dashboard using SwiftUI. (Even if it never ships, I think the work will be educational.)
The main component of this page is going to be a scrolling list of cards. That seems like fairly generic functionality, so I wrote this paginating/refreshable
VStackas a generic implementation of it.👀 See
Here's what the example view looks like - it supports infinite scroll and pull-to-refresh.