Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MBL-1306: Added tests #2029

Merged
merged 2 commits into from May 7, 2024
Merged

MBL-1306: Added tests #2029

merged 2 commits into from May 7, 2024

Conversation

Arkariang
Copy link
Contributor

@Arkariang Arkariang commented May 2, 2024

📲 What

All networking was covered for error states already, so took the chance to add a few tests :

🤔 Why

  • More tests always welcome!

👀 See

  • nothing to qa just tests

| | |

📋 QA

  • nothing to qa just tests

Story 📖

MBL-1306

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@7868ad4). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2029   +/-   ##
=========================================
  Coverage          ?   67.39%           
  Complexity        ?     2068           
=========================================
  Files             ?      353           
  Lines             ?    21472           
  Branches          ?     3029           
=========================================
  Hits              ?    14472           
  Misses            ?     5389           
  Partials          ?     1611           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arkariang Arkariang marked this pull request as ready for review May 6, 2024 16:13
@Arkariang Arkariang self-assigned this May 6, 2024
@Arkariang Arkariang added maintenance 🗜 Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108 labels May 6, 2024
@Arkariang Arkariang merged commit 7f7cbf7 into master May 7, 2024
3 checks passed
@Arkariang Arkariang deleted the imartin/MBL-1306 branch May 7, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance 🗜 Post Campaign Functionality Tied to Epic https://kickstarter.atlassian.net/browse/MBL-1108
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants