Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify waypoint proxies #7351

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Identify waypoint proxies #7351

wants to merge 6 commits into from

Conversation

josunect
Copy link
Contributor

@josunect josunect commented May 10, 2024

Describe the change

The labels for the waypoint proxies had changed:

  • Not using pod.Labels["istio.io/gateway-name"] == "namespace" or pod.Annotations["istio.io/for-service-account"]
  • It is using istio.io/use-waypoint equals to the waypoint name

Steps to test the PR

  • Use Istio > 1.22.rc
  • Apply different waypoint proxies and check if Kiali identifies them correctly:
    • namespace
    • pod
    • service

image

Automation testing

Added end to end testing to tests:

  • waypoint proxie is identified correctly.
  • workload is enrolled by pod
  • workload is enrolled by ns
  • workload is enrolled by service

Issue reference

#7350

@josunect josunect added enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic ambient Related to Istio Ambient Mesh labels May 10, 2024
@josunect josunect self-assigned this May 10, 2024
@josunect josunect added the test: back-end/integration PR adds/updates back-end tests (unit and/or integration) label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ambient Related to Istio Ambient Mesh enhancement This is the preferred way to describe new end-to-end features. sub-task Ties an issue to an epic test: back-end/integration PR adds/updates back-end tests (unit and/or integration)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant