Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztunnel logs with multiple nodes #7339

Merged
merged 7 commits into from May 10, 2024
Merged

ztunnel logs with multiple nodes #7339

merged 7 commits into from May 10, 2024

Conversation

josunect
Copy link
Contributor

@josunect josunect commented May 6, 2024

Describe the change

Create an array of pod names from the same namespace from streamParsedLogs to be able to stream the logs from different nodes for ztunnel.

Include the ztunnel pod in the log line:

image

Steps to test the PR

Create a Ambient kind cluster with more than one node. Then:

  1. istio/download-istio.sh -div 1.22-dev
    
  2. Install Istio: istio/install-istio-via-istioctl.sh -c kubectl -cp ambient -it default -ih default
    
  3. Install Kiali
    
  4. Install bookinfo: istio/install-bookinfo-demo.sh -c kubectl -ai false -tg
    

Go to the logs page, click in ztunnel logs. Add different combinations of number of lines, change the containers/log options.
ztunnel logs should be visible.

Automation testing

existing integration tests. 2e2 test will be added for Istio 1.22.

Issue reference

Fixes #7338

@josunect josunect self-assigned this May 6, 2024
@josunect josunect added bug Something isn't working ambient Related to Istio Ambient Mesh labels May 6, 2024
@josunect josunect changed the title Issue7338 ztunnel logs with multiple nodes May 7, 2024
@josunect josunect marked this pull request as ready for review May 7, 2024 10:25
@josunect josunect requested review from hhovsepy and jshaughn May 7, 2024 10:29
Copy link
Contributor

@hhovsepy hhovsepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on Istio 1.22-dev, regression tested on Istio 1.21.2

@josunect josunect merged commit 7cd66f0 into kiali:master May 10, 2024
9 checks passed
@josunect josunect deleted the issue7338 branch May 10, 2024 06:26
@jshaughn jshaughn added the test: back-end/integration PR adds/updates back-end tests (unit and/or integration) label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ambient Related to Istio Ambient Mesh bug Something isn't working test: back-end/integration PR adds/updates back-end tests (unit and/or integration)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ztunnel logs are not shown on a kind cluster
3 participants