Replace old Mesh page with New Mesh page #7321
Conversation
jshaughn
force-pushed
the
kiali7298
branch
5 times, most recently
from
3385e1b
to
96ba4c8
Compare
jshaughn
force-pushed
the
kiali7298
branch
3 times, most recently
from
cb0d842
to
76a5f6c
Compare
|
It is not related with this PR, but I think istio status should take into account both istiod and istio pod status. Currently it only takes into account istiod, show it shows a
@jshaughn I can create a different issue or fix it in this PR, as you consider. |
@ferhoyos +1, a different issue or a PR against this PR is fine. This PR is mostly stable with changes only resulting from adding test code or making fixes. I made your suggested change about treating Data Plane and Kiali as Healthy (basically, if there is no health assigned then it defaults to Healthy). I also applied your suggestion about embedding the JSON config into the Data Plane expandable sections. |
jshaughn
force-pushed
the
kiali7298
branch
2 times, most recently
from
687c406
to
b948d27
Compare
jshaughn
added
test: front-end/cypress
|
Tested on Multicluster, single cluster and in Ambient mode, works fine, currently checking on OCP cluster (will take longer due to env issues): |
|
Tested on OCP, working fine, just one question, the component's versions are undefined, does any config missing: at least Grafana has a version: |
|
Did a first run on Minikube and works well and I really like how it looks and how the information is grouped.
The collapsible namespaces for the data plane is awesome. One minor thing that I guess can be improve is that when you have a namespace with no inbount and outbound traffic, it can be a small indication of this situation (to avoid the size of the empty graphs):
Related to versions, I do notice that Jaeger and Grafana versions are unknown. I will start the proper code review and probably a canary/mc testing too now, but I'm very happy with this new mesh page!. |
issue with DataPlane nodes for canary versions, and possibly other situations.
- fix double-revision in istiod name - add I18N to UNKNOWN constant, and use as opposed to literal - mesh side panel - for clarity, increase indent on infra - for conciseness, remove namespace for non-istiod - sort infra, and move istiod(s) to top
- remove the "no canary" test from overview, it's irrelevant - add a missing @sleep-app to an overview test
- Add version info for grafana via API, if possible - note that tracing version may be unavailable via api, or may need a different approach
- reduce whitespace for dataplane namespace, when it lacks chart metrics
|
@hhovsepy , @leandroberetta , @ferhoyos , I pushed changes that should now show Grafana version, if available (tracing version is still not solved). Also, I reduced the vertical whitespace in an expanded data plane namespace, when it lacks traffic for the charts. |
Determine Jaeger version
|
Hi @hhovsepy , @leandroberetta , We've incorporated your feedback. If public URLs can be determined then we can show the Grafana and Jaeger version info: And we've fixed the excessive whitespace when no metrics are available for a data plane namespace: The CI failures are limited to the know issue with multi-primary. If you are OK with the state of things, please approve and we'll get this in for some soak time prior to sprint end. If you have more suggestions we can follow up with other issues for the Epic. Of course if you see a blocking issue we'll fix it in this PR. Thanks! |
|
Hi @jshaughn , the components versions are fixed, thanks. |
Hi @hhovsepy Hmm, As shown in my screenshot above, I am seeing the cluster version on my CRC 4.14, using the default "Kubernetes". I'm not sure why you don't get it, but I guess it means that you don't have it set in the return from GetStatus(). Try a call to |
|
@jshaughn right, probably this is a separate issue as API does not return cluster version. |
This PR replaces the old Mesh page with the new Mesh page, removing the undocumented feature flag. It should contain a releasable version.
Closes #7298
Closes #6431
TESTING
The PR removes the new mesh page feature flag, and so it should appear as the default Mesh Page. The goal of the first release of the page is not perfection, but it should be solid, usable, and useful. It replaces the old mesh page, the non-Kiali parts of the About page, and demotes the Overview Control plane card to a standard card (although it will still be labeled as a control plane). It should be able to handle standard deployments, multi-cluster deployments, canary upgrades, and externally deployed infra (you don't necessarily have to test all of these things).