Realign healthy icon in summary panel graph #6885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @ferhoyos thank you, |
|
@hhovsepy yes I am aware of this issue, but we cannot do anything since it is caused by Patternfly library. I reported the issue some time ago and PF team fixes it recently, so I guess this fix will be included in the next PF release (5.2.0). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Realign healthy icon in summary panel graph next to application/service badge link instead of previous label.
Previous:
Now:
I have removed
healthlabel in order to be consistent with other parts of Kiali where health indicator is placed next to application/service name (e.g. detail info):Besides, I have reduced a bit the top padding of kebab toggle menu in graph and overview:
Issue reference
Fixes #6884