Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be able to set DNS policy and config on the Kiali pod #768

Merged
merged 1 commit into from May 13, 2024
Merged

be able to set DNS policy and config on the Kiali pod #768

merged 1 commit into from May 13, 2024

Conversation

jmazzitelli
Copy link
Contributor

@jmazzitelli jmazzitelli self-assigned this May 7, 2024
@jmazzitelli jmazzitelli force-pushed the 7150-dns-config branch 2 times, most recently from 39c46b9 to de9a92a Compare May 7, 2024 15:46
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented May 7, 2024 •
edited

config-values-test molecule test is testing this operator feature.

  1. Start a minikube cluster (e.g. hack/k8s-minikube.sh start)
  2. Build and push the server and the operator: make -e CLUSTER_TYPE=minikube build build-ui cluster-push
  3. Run molecule test, using the dev image you just pushed
./hack/run-molecule-tests.sh --client-exe "$(which kubectl)"  --minikube-exe $(which minikube) --cluster-type minikube --use-dev-images true -at config-values-test
  1. make validate-cr can also be run so it confirms the crd documentation and example are good.

@jmazzitelli jmazzitelli mentioned this pull request May 7, 2024
Closed
@jmazzitelli
Copy link
Contributor Author

jmazzitelli commented May 7, 2024 •
edited

(just noting that there is no need to run the dns config through the snake-case-to-camel-case converter code - there are no camelCase settings in the kubernetes dnsConfig child properties so there is nothing to convert.)

@jshaughn jshaughn self-requested a review May 13, 2024 14:17
@jshaughn jshaughn added the test: molecule Molecule test infrastructure and tests themselves label May 13, 2024
jshaughn
jshaughn approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@jshaughn jshaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

molecule testing passed.

@jmazzitelli jmazzitelli merged commit 15aa80b into kiali:master May 13, 2024
1 check passed
@jmazzitelli jmazzitelli deleted the 7150-dns-config branch May 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jshaughn jshaughn jshaughn approved these changes

Assignees

@jmazzitelli jmazzitelli

Labels
requires helm chart PR test: molecule Molecule test infrastructure and tests themselves
Projects
Kiali Sprint 24-6 | Kiali 1.85
Status: ✅ Done
Milestone
No milestone
2 participants
@jmazzitelli @jshaughn