Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to modify the dnsconfig for the kiali deployment in kubernetes #7150

Closed
ceastman-r7 opened this issue Feb 22, 2024 · 8 comments · Fixed by kiali/kiali-operator#768
Closed

Add the ability to modify the dnsconfig for the kiali deployment in kubernetes #7150

ceastman-r7 opened this issue Feb 22, 2024 · 8 comments · Fixed by kiali/kiali-operator#768
Assignees
@jmazzitelli
Labels
enhancement This is the preferred way to describe new end-to-end features.

Comments

@ceastman-r7
Copy link

What do you want to improve?

Allow the ability to add a dnsconfig option to the deployment spec

mainly to have the following:
dnsConfig: options: - name: ndots value: "1"

What is the current behavior?

current behavior is to have ndots default to 5

From the resolv.conf man:

ndots:n

sets a threshold for the number of dots which must appear in a name before an initial absolute query will be made. The default for n is 5, meaning that if there are any dots in a name, the name will be tried first as an absolute name before any search list elements are appended to it

in aws kubernetes the typically resolv.conf is as follows:
search apps.svc.cluster.local svc.cluster.local cluster.local us-east-2.compute.internal
nameserver 172.20.0.10
options ndots:5

What is the new behavior?

All the default dnsconfig to be overridden to allow ndots: 1
@ceastman-r7 ceastman-r7 added the enhancement This is the preferred way to describe new end-to-end features. label Feb 22, 2024
@jshaughn jshaughn added the refinement Still being full defined before taking any action label Feb 26, 2024
@jshaughn
Copy link
Collaborator

@jmazzitelli Can you follow up with @ceastman-r7 and make sure we better understand the ask here?

@jmazzitelli
Copy link
Collaborator

@ceastman-r7 what are looking for here? Is this to be an additional setting in the Kiali CR's spec.deployment section ?

This part of your issue description is confusing me:

mainly to have the following:
dnsConfig: options: - name: ndots value: "1"

@jshaughn
Copy link
Collaborator

jshaughn commented May 5, 2024

@ceastman-r7 Can you answer the question above?

@jshaughn jshaughn added stale Issue has no activity waiting external It requires additional info to progress. For example, it can require a fix in other project. and removed refinement Still being full defined before taking any action labels May 5, 2024
@ceastman-r7
Copy link
Author

ceastman-r7 commented May 6, 2024 •
edited

For instance the ask is to have the ability to add a configuration so that the pod yaml looks like the following:
`
dnsConfig:
options:
- name: ndots
value: "1"
dnsPolicy: ClusterFirst

`

@jshaughn
Copy link
Collaborator

jshaughn commented May 6, 2024

@jmazzitelli Does that give you enough context?

@jshaughn jshaughn added refinement Still being full defined before taking any action and removed stale Issue has no activity waiting external It requires additional info to progress. For example, it can require a fix in other project. labels May 6, 2024
@jmazzitelli
Copy link
Collaborator

For instance the ask is to have the ability to add a configuration so that the pod yaml looks like the following:

Can you reformat that :) You want triple-backticks to format in yaml.

I'm guessing you want to configure this: https://kubernetes.io/docs/concepts/services-networking/dns-pod-service/#pod-dns-config

@ceastman-r7
Copy link
Author 

      dnsConfig:
        options:
        - name: ndots
          value: "1"
      dnsPolicy: ClusterFirst

@jmazzitelli jmazzitelli self-assigned this May 7, 2024
jmazzitelli added a commit to jmazzitelli/helm-charts that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
cc3642b 
part of kiali/kiali#7150
@jmazzitelli jmazzitelli mentioned this issue May 7, 2024
Merged
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
48419f6 
fixes: kiali/kiali#7150
@jmazzitelli jmazzitelli mentioned this issue May 7, 2024
Merged
jmazzitelli added a commit to jmazzitelli/helm-charts that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
70e128d 
part of kiali/kiali#7150
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
39c46b9 
fixes: kiali/kiali#7150
jmazzitelli added a commit to jmazzitelli/helm-charts that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
c1a687a 
part of kiali/kiali#7150
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
de9a92a 
fixes: kiali/kiali#7150
jmazzitelli added a commit to jmazzitelli/kiali-operator that referenced this issue May 7, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod
2e4e3ac 
fixes: kiali/kiali#7150
@jmazzitelli
Copy link
Collaborator

This is ready for review. This new feature should be available in the next sprint release due in about 3 weeks.

PRs:

@jshaughn jshaughn removed the refinement Still being full defined before taking any action label May 13, 2024
jmazzitelli added a commit to kiali/helm-charts that referenced this issue May 13, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod (#260)
cb4aebc 
part of kiali/kiali#7150
jmazzitelli added a commit to kiali/kiali-operator that referenced this issue May 13, 2024
@jmazzitelli
be able to set DNS policy and config on the Kiali pod (#768)
15aa80b 
fixes: kiali/kiali#7150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmazzitelli jmazzitelli

Labels
enhancement This is the preferred way to describe new end-to-end features.
Projects
Kiali Sprint 24-6 | Kiali 1.85
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

be able to set DNS policy and config on the Kiali pod jmazzitelli/kiali-operator
3 participants
@jmazzitelli @jshaughn @ceastman-r7