Add ordinal adverb support #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ordinal adverbs (firstly, secondly, thirdly) using arNumberOrder=3
|
Hi @jvarn, I am sorry to be late in reviewing your pull request! Your idea is valid and has added value, but I need to review the processing logic a little within the coming couple of days. The first impression made me hesitate about the robustness and completeness of handling all possible scenarios in a clear way. |
|
Thank you, Khaled. I agree, this implementation isn't particularly future-proof or user-friendly. Using 1,2 for a binary option is fair enough, but 1,2,3 is inelegant, to say the least. I endeavoured to implement the required logic based upon existing code without any refactoring or major additions, and couldn't think of a better way to do it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a new number order option (arNumberOrder=3) with default gender (arNumberFeminine=1) this adds support for ordinal adverbs (i.e. firstly, secondly, thirdly).
(Existing) ordinal numbers with arNumberOrder=2
(New) ordinal adverbs with arNumberOrder=3