Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gams_dir can be explicitly defined #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kavvkon
Copy link

@kavvkon kavvkon commented Apr 12, 2018

I had trouble running the library without defining explicitly the gams directory as my GAMS installaiton couldn't be located by 'which'.

Moreover I added gdxcc as a requirement in setup.py so that it can be automatically installed by pypi (maintained by me here )

@khaeru
Copy link
Owner

khaeru commented Apr 12, 2018

Great to see that someone's figured out how to package gdxcc! Honestly, the most laborious part of maintaining this package has been helping my colleagues do that first step of installing the low-level bindings. That should help a lot.

Happy to merge this shortly, but one question first—are you using Windows? I previously noted there was a program where available, so I was thinking to expand api._gams_dir() to (1) check sys.platform and (2) try where gams.exe to identify the gams_dir.

If you want to take a stab at that, it would be (even more) appreciated. But if you're not on Windows, that's fine—I'll just merge it directly.

@khaeru khaeru added this to the v4 milestone Apr 12, 2018
@kavvkon
Copy link
Author

kavvkon commented Apr 12, 2018

Hey, glad you liked it. I will propose something as we have this kind of checks in another piece of code.

I have both windows and linux and shutil works in the same way I think..

@khaeru khaeru self-assigned this Jan 4, 2021
@khaeru khaeru removed their assignment Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants