fix: adds handling for a KC_CLI_PASSWORD env variable #29430
+95
−306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keycloak-github-bot
bot
added
team/cloud-native
team/core-clients
team/core-iam
flaky-test
labels
This was referenced May 9, 2024
Closed
vmuzikar
reviewed
May 20, 2024
...on/client-cli/admin-cli/src/main/java/org/keycloak/client/cli/common/BaseAuthOptionsCmd.java
Outdated
Show resolved
Hide resolved
...ent-cli/admin-cli/src/main/java/org/keycloak/client/cli/common/BaseConfigCredentialsCmd.java
Outdated
Show resolved
Hide resolved
vmuzikar
reviewed
May 20, 2024
...on/client-cli/admin-cli/src/main/java/org/keycloak/client/cli/common/BaseAuthOptionsCmd.java
Outdated
Show resolved
Hide resolved
|
@vmuzikar updated the punctuation / typo. I'm now thinking this is probably too narrow in scope. Users would expect the same behavior for the client secret, store pass, etc. Does it seem ok to expend the effort for all of these? |
Works for me. |
shawkins
force-pushed
the
iss21961
branch
3 times, most recently
from
ec86078
to
1e26c33
Compare
closes: keycloak#21961 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
|
@vmuzikar updated to all kcadm sensitive options, which covers some of kcreg as well. Added a few mentions in the docs. Can also add a v26 release note if desired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #21961
Went the route of picocli defaults for this. We could consider adding a general default handler, but option keys for the "secrets" don't seem consistent.
The other possible "secret" env variables (not addressed in this pr) include: