Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix user-facing typos in error messages #29326

Merged
merged 1 commit into from May 16, 2024
Merged

Fix user-facing typos in error messages #29326

merged 1 commit into from May 16, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 6, 2024 •
edited

Follow-up to #28971.

  • I tried to exclude log messages.
  • I have refrained from fixing unsecure → insecure, because the use of unsecure is pervasive in the API and log files.

Fixes #29352.

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request May 6, 2024
Merged
This was referenced May 6, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the codespell_error branch 6 times, most recently from 414cc15 to 1762441 Compare May 7, 2024 11:46
martin-kanis
martin-kanis approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@martin-kanis martin-kanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DimitriPapadopoulos Thanks for the PR, looks good. You can optionally squash the commits but I can ask a maintainer to do it when merging.

@mhajas mhajas marked this pull request as ready for review May 15, 2024 13:03
@mhajas mhajas requested review from a team as code owners May 15, 2024 13:03
@mhajas
Copy link
Contributor

mhajas commented May 15, 2024

@DimitriPapadopoulos Is this PR ready for merging or do you plan to add additional fixes?

@mhajas mhajas marked this pull request as draft May 15, 2024 13:05
@DimitriPapadopoulos
Fix user-facing typos in error messages
bbe5d35 
Update resource file and tests accordingly

Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
@DimitriPapadopoulos
Copy link
Contributor Author

I think it's ready to be merged. Just squashed the commits as requested.

@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review May 15, 2024 14:40
@keycloak-github-bot keycloak-github-bot bot mentioned this pull request May 15, 2024
Open
mhajas
mhajas approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@mhajas mhajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DimitriPapadopoulos

@mhajas mhajas merged commit 64a145e into keycloak:main May 16, 2024
70 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell_error branch May 17, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-kanis martin-kanis martin-kanis approved these changes

@mhajas mhajas mhajas approved these changes

Assignees
No one assigned
Labels
flaky-test team/cloud-native team/core-clients team/core-iam
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix user-facing typos in error messages
3 participants
@DimitriPapadopoulos @mhajas @martin-kanis