feat: add Option to Control keys #291
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening a PR, but the option to include the option key in the set of control keys needs to also be a user-facing option for the default visualizer, as option is not a control key, it is a modifier key. |
|
A more ideal solution to this feature request is to have a progression from control keys only, to all modified keys (i.e. shift and option), then all keystrokes. This warrants some thought in the preferences UI as well. |
|
Maybe we can add an option in the preferences or change the label to "only modifier keys"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This development adds the option key to the keys to be displayed when only control keys are selected in the preferences