Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stubs/httpx): fix decode error on utf-8 response with file #820

Closed
wants to merge 2 commits into from

Conversation

kszinhu
Copy link

@kszinhu kszinhu commented Feb 5, 2024

On httpx response should be read with ignore error

@hartwork

- on httpx response, body has file, so it should be read with ignore error
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (68038d0) 92.32% compared to head (f67eac4) 92.32%.
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files          27       27           
  Lines        1811     1811           
  Branches      338      338           
=======================================
  Hits         1672     1672           
  Misses         92       92           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@76tr75b
Copy link

76tr75b commented Mar 7, 2024

Can we get this merged? It solves the issue when recording file uploads with httpx.

Copy link
Collaborator

@hartwork hartwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain why this fix would make sense. In particular hardcoding ISO-8859-1 and serving bytes on one "branch" but a string in the other seems… very surprising. What is the idea?

@hartwork
Copy link
Collaborator

hartwork commented Jun 2, 2024

Closing as "mistaken until proven otherwise" and due to lack of a reply…

@hartwork hartwork closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants