add support for delft layout features for label task #459
+56
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-code
changed the title
de-code
force-pushed
the
add-support-for-delft-layout-features
branch
from
71d5730
to
743a2bf
Compare
de-code
force-pushed
the
add-support-for-delft-layout-features
branch
from
743a2bf
to
e70b72c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for DeLFT layout features on the GROBID side.
To actually work, it would also need the support on the DeLFT side (which I have currently implemented in sciencebeam-trainer-delft).
It should be backward compatible.
I added an optional configuration option for the package, which allows me to use my own Python package rather than
delft(which I use in part, but currently extend heavily - until a similar change is ported back)This is currently only implemented for the label task (not the train task).
Not sure whether implementing it for the training task is a priority. Judging by the comments, the JNI method for training doesn't seem to be stable. And the
grobidTagger.pyof the current DeLFT version itself doesn't support it anyway./cc @kermitt2