Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name arg to MobileNet V1 and V2 #19712

Merged
merged 1 commit into from
May 13, 2024

Conversation

jeffcarp
Copy link
Collaborator

Followup from #19695 and 2b7120b.

@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.47%. Comparing base (310c275) to head (05b9c38).

Files Patch % Lines
keras/src/applications/mobilenet.py 66.66% 0 Missing and 1 partial ⚠️
keras/src/applications/mobilenet_v2.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19712      +/-   ##
==========================================
+ Coverage   78.52%   81.47%   +2.94%     
==========================================
  Files         498      498              
  Lines       45769    45773       +4     
  Branches     8456     8458       +2     
==========================================
+ Hits        35942    37294    +1352     
+ Misses       8091     6577    -1514     
- Partials     1736     1902     +166     
Flag Coverage Δ
keras 81.32% <66.66%> (+2.94%) ⬆️
keras-jax 64.89% <66.66%> (+2.94%) ⬆️
keras-numpy 56.44% <0.00%> (+0.15%) ⬆️
keras-tensorflow 66.36% <66.66%> (+2.94%) ⬆️
keras-torch 64.94% <66.66%> (+2.93%) ⬆️
keras.applications 80.40% <66.66%> (?)
keras.applications-jax 80.40% <66.66%> (?)
keras.applications-numpy 22.95% <0.00%> (?)
keras.applications-tensorflow 80.40% <66.66%> (?)
keras.applications-torch 80.13% <66.66%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 13, 2024
@fchollet fchollet merged commit 669a97a into keras-team:master May 13, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants