Improved docs to bring in clarity. #19710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19710 +/- ##
=======================================
Coverage 78.52% 78.52%
=======================================
Files 498 498
Lines 45769 45769
Branches 8456 8456
=======================================
Hits 35942 35942
Misses 8092 8092
Partials 1735 1735
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fchollet
approved these changes
May 11, 2024
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR consists of a tiny addition in docs to let the user know that
TorchModuleWrapper, as the name sounds is not a Wrapper to Wrap any arbitrary code into Keras with any backend, but rather a different feature enabling integration of PyTorch custom layers to Keras when running PyTorch backends.I'll try to write basic wrappers for actual code conversion if that is possible and try checking the extent by which complex models can be easily integrated into Keras, being backend invariant.
Thank You.