Fix ops.shape() for tf.RaggedTensor.
#19707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the TensorFlow backend, when passing a `RaggedTensor`, the dynamic shape returned by `tf.shape` is an object that raises an exception when a ragged dimension is accessed. We catch it and leave the dimension as `None`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19707 +/- ##
==========================================
- Coverage 78.52% 68.82% -9.71%
==========================================
Files 498 498
Lines 45763 45769 +6
Branches 8455 8456 +1
==========================================
- Hits 35936 31499 -4437
- Misses 8092 12681 +4589
+ Partials 1735 1589 -146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the TensorFlow backend, when passing a
RaggedTensor, the dynamic shape returned bytf.shapeis an object that raises an exception when a ragged dimension is accessed. We catch it and leave the dimension asNone.